Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadcn: init at 2.0.3 #340035

Merged
merged 1 commit into from
Nov 1, 2024
Merged

shadcn: init at 2.0.3 #340035

merged 1 commit into from
Nov 1, 2024

Conversation

GetPsyched
Copy link
Member

Description of changes

Adds the newly released ShadCN CLI.
Docs: https://ui.shadcn.com/docs/cli

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix code LGTM

.cache/nixpkgs-review/pr-340035-1 ❄️ >>> time shadcn --version
2.0.3

________________________________________________________
Executed in  670.43 millis    fish           external
   usr time  727.78 millis    0.00 micros  727.78 millis
   sys time  277.05 millis  886.00 micros  276.16 millis

@donovanglover donovanglover added 6.topic: nodejs 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 7, 2024
@GetPsyched
Copy link
Member Author

Added a version test.

Not sure why it takes long as it does, it's likely to do something with upstream maybe.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 14, 2024
@Aleksanaa Aleksanaa merged commit 69f4579 into NixOS:master Nov 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants