Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/overlayfs: add a switch to disable prefixing with /sysroot for initrd mounts #340763

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Sep 9, 2024

Description of changes

This enables mounting paths from the initrd into the real root with the overlayfs abstraction, which can be useful in some cases, e.g. to create an overlay in the real root without a visible upper-/workdir in the real root.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft msanft requested a review from nikstur September 9, 2024 12:16
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 9, 2024
Copy link
Contributor

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if you could add a test case that exercises this functionality. Maybe in tests/filesystems-overlayfs.

nixos/modules/tasks/filesystems/overlayfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/overlayfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/overlayfs.nix Outdated Show resolved Hide resolved
@msanft msanft force-pushed the msanft/overlayfs/dontprefix branch 2 times, most recently from eae0c60 to 54b89b3 Compare November 4, 2024 11:56
@msanft msanft requested a review from nikstur November 4, 2024 12:27
@msanft msanft force-pushed the msanft/overlayfs/dontprefix branch from ce57596 to d2c5cc3 Compare November 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants