-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetrio-plus: split into seperate derivation #341251
Conversation
184325e
to
fe9a069
Compare
seems like there's a precedent for this with Vencord and OpenASAR, so LGTM!
sounds good to me!
I think so. |
9f907e4
to
9a3fc26
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1954 |
@NixOS/nixpkgs-merge-bot merge Edit: oooh that's how it works, that makes a lot of sense... that's kinda cool |
@huantianad merge not permitted (#305350): |
1 similar comment
@huantianad merge not permitted (#305350): |
rev = "electron-v${version}-tetrio-v${lib.versions.major tetrio-desktop.version}"; | ||
|
||
src = fetchFromGitLab { | ||
owner = "UniQMG"; | ||
repo = "tetrio-plus"; | ||
rev = "electron-v${version}-tetrio-v${lib.versions.major tetrio-version}"; | ||
inherit rev; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move rev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used in changelog, wanted to reduce duplication, can revert.
9a3fc26
to
5cc321e
Compare
Upstream brands each version as "v9" or "Version 9" for example, and tools like TETR.IO PLUS also use only the major version.
5cc321e
to
19616e7
Compare
19616e7
to
d7d7797
Compare
I've split the 'tetrio-plus: split into seperate derivation' commit into two commits to hopefully make the changes a bit clearer; let me know if some of the commits make sense to be squashed. |
Description of changes
This allows the tetrio-plus package to be cached, so users don't have to compile tpsecore themselves.
@wackbyte let me know if this is something we even want to do.
Questions:
tetrio-desktop
'sversion
to just be9
? Upstream seems to only be using integer versions, and it would save us somelib.versions.major
calls.tetrio-desktop
'ssrc
andversion
like this in general?Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.