Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all-contributors-cli: init at 6.26.1 #341464

Closed
wants to merge 2 commits into from
Closed

Conversation

mahtaran
Copy link

Description of changes

CLI for All Contributors. See the documentation for more details.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 12, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 13, 2024
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Could you package this with yarnConfigHook and so on?
https://nixos.org/manual/nixpkgs/unstable/#javascript-yarn
Unfortunately, we can no longer accept new nodePackages. see #229475

Signed-off-by: Luka Leer <[email protected]>
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` and removed 6.topic: nodejs labels Sep 14, 2024
@mahtaran mahtaran changed the title nodePackages.all-contributors-cli: init at 6.26.1 all-contributors-cli: init at 6.26.1 Sep 14, 2024
@mahtaran mahtaran marked this pull request as draft September 14, 2024 20:59
@mahtaran
Copy link
Author

Thanks for your contribution!

Could you package this with yarnConfigHook and so on? nixos.org/manual/nixpkgs/unstable#javascript-yarn Unfortunately, we can no longer accept new nodePackages. see #229475

Ah! Thanks for the information. I wondered why the script took so long to build …

I've attempted reimplementing this with the newer method, but ran into some issues with the lockfile as the upstream repo doesn't provide one. It seems like something goes wrong when prefetching the dependencies. Any clue as to what could be causing this?

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 14, 2024
@mahtaran
Copy link
Author

Seems like upstream has more issues and isn't really maintained any more in favour of the GitHub bot, so I'll close this for now

@mahtaran mahtaran closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants