Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc7, gcc7Stdenv, gfortran7: remove old implementation #342242

Closed
wants to merge 2 commits into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Sep 16, 2024

Description of changes

gcc-7.5.0 was released in Nov 14, 2019, 5 years ago. It's a branch that
went out of support years ago. Numerous bugs never get backported to
this version.

Let's remove it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`gcc7` will soon be removed from `nixpkgs`. Switch the package to use a
default version of `gcc`.
gcc-7.5.0 was released in Nov 14, 2019, 5 years ago. It's a branch that
went out of support years ago. Numerous bugs never get backported to
this version.

Let's remove it.
@trofi
Copy link
Contributor Author

trofi commented Sep 16, 2024

Result of nixpkgs-review pr 342242 run on x86_64-linux 1

1 package built:
  • blackmagic-desktop-video

@trofi
Copy link
Contributor Author

trofi commented Sep 16, 2024

If #342235 is merged earlier I can rebase past it to get 0 rebuilds on this PR.

@trofi trofi marked this pull request as draft September 16, 2024 10:04
@trofi
Copy link
Contributor Author

trofi commented Sep 16, 2024

Will need cuda changes:

1|   gccMajorVersion = nvccCompatibilities.${cudaVersion}.gccMaxMajorVersion;
           12|   cudaStdenv = stdenvAdapters.useLibsFrom stdenv pkgs."gcc${gccMajorVersion}Stdenv";
             |                                                  ^
           13|   passthruExtra = {
       Did you mean one of gcc8Stdenv, gcc9Stdenv, gccStdenv, gcc10Stdenv or gcc11Stdenv?

@emilazy
Copy link
Member

emilazy commented Sep 16, 2024

It needs to wait until after branch‐off; see #342112.

I intend to remove GCCs 7 through 10 at that point to align with upstream’s support policy. (I have confirmed that all packages using GCC 9 should be possible to migrate off, and nothing uses 8. It’s possible 10 will have to stick around for now, depending on how that goes.)

@emilazy
Copy link
Member

emilazy commented Sep 16, 2024

Also QMK would need looking at, I think?

@trofi trofi closed this Sep 16, 2024
@trofi trofi deleted the gcc7-removal branch September 16, 2024 11:16
@emilazy
Copy link
Member

emilazy commented Sep 16, 2024

(Thank you for taking the charge in getting these cleaned up!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants