corretto{11,17,21}: {11.0.23.9.1,17.0.11.9.1,21.0.3.9.1} -> {11.0.24.… #342262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
can you split nixfmt changes into a separate commit to make it easier to review? |
rollf
force-pushed
the
corretto-updates
branch
from
7db37c6
to
1707c92
Compare
|
@chayleaf I have separated the changes into 2 commits. |
|
Result of 6 packages built:
|
chayleaf
approved these changes
Sep 22, 2024
wegank
added
the
12.approvals: 1
…8.1,17.0.12.7.1,21.0.4.7.1}
|
Please fix the merge conflict. |
|
Yes, I'm on it. This came by #341407 . I am currently compiling locally. |
rollf
force-pushed
the
corretto-updates
branch
from
1707c92
to
a0bec3f
Compare
wegank
removed
the
12.approvals: 1
|
Okay, this PR is green again. |
|
@emilazy Would you be able to merge this? |
|
Sorry for forgetting about this! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…8.1,17.0.12.7.1,21.0.4.7.1}
nixfmthas changed a lot. Other than that, there is only version bump and a comment update.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.