Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloudPackages.whiteboard: init at 1.0.4; nextcloudPackages: update #342773

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 18, 2024

Description of changes

Add whiteboard to package set https://github.com/nextcloud/whiteboard

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 18, 2024
@onny onny changed the title nextcloudPackages.whiteboard: init at 1.0.1; nextcloudPackages: update nextcloudPackages.whiteboard: init at 1.0.2; nextcloudPackages: update Sep 24, 2024
@onny onny requested a review from dotlambda September 24, 2024 12:34
@dotlambda
Copy link
Member

We should also package the backend and add a service.

@pyrox0
Copy link
Member

pyrox0 commented Sep 24, 2024

I am not a maintainer for this package set, please do not request reviews from me on it.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 25, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 25, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 26, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 26, 2024
@onny
Copy link
Contributor Author

onny commented Sep 26, 2024

@dotlambda Good point, packaged the backend server and added an module for it.

Works for me

  environment.etc."nextcloud-admin-pass".text = "test123";
  services.nextcloud = {
    enable = true;
    hostName = "localhost";
    extraApps = {
      inherit (config.services.nextcloud.package.packages.apps) whiteboard;
    };
    extraAppsEnable = true;
    config.adminpassFile = "/etc/nextcloud-admin-pass";
  };

  services.nextcloud-whiteboard-server = {
    enable = true;
    settings = {
      NEXTCLOUD_URL = "http://localhost";
      JWT_SECRET_KEY = "test123";
    };
  };
nextcloud-occ config:app:set whiteboard collabBackendUrl --value="http://localhost:3002"
nextcloud-occ config:app:set whiteboard jwt_secret_key --value="test123"

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the module. Everything else is looking good.

@onny onny changed the title nextcloudPackages.whiteboard: init at 1.0.2; nextcloudPackages: update nextcloudPackages.whiteboard: init at 1.0.4; nextcloudPackages: update Oct 21, 2024
@onny onny force-pushed the nextcloud-whiteboard branch 2 times, most recently from 56dd35a to 79cf655 Compare October 21, 2024 15:37
@onny
Copy link
Contributor Author

onny commented Oct 21, 2024

Thank you @Ma27 fixed it 👍

@onny onny requested a review from happysalada October 22, 2024 13:54
@happysalada happysalada merged commit e7d7f71 into NixOS:master Oct 22, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants