Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser: 13.5.3 -> 13.5.4 #342827

Merged
merged 1 commit into from
Sep 19, 2024
Merged

tor-browser: 13.5.3 -> 13.5.4 #342827

merged 1 commit into from
Sep 19, 2024

Conversation

felschr
Copy link
Member

@felschr felschr commented Sep 18, 2024 •
edited
Loading

Description of changes

https://blog.torproject.org/new-release-tor-browser-1354/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felschr felschr added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 Backport PR automatically and removed 1.severity: security Issues which raise a security issue, or PRs that fix one labels Sep 18, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 18, 2024
panicgh
panicgh approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@panicgh panicgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testes a bit of browsing, video and audio and had no issues.

Result of nixpkgs-review pr 342827 run on x86_64-linux 1

1 package built:
  • tor-browser

@panicgh
Copy link
Contributor

panicgh commented Sep 19, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@panicgh merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@felschr felschr merged commit f412b6b into NixOS:master Sep 19, 2024
45 of 47 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Merged
1 task
@felschr felschr deleted the tor-browser-updates branch September 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panicgh panicgh panicgh approved these changes

@joachifm joachifm Awaiting requested review from joachifm

@hax404 hax404 Awaiting requested review from hax404

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felschr @panicgh