Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slackdump: init at 2.5.11 #343156

Merged
merged 1 commit into from
Nov 6, 2024
Merged

slackdump: init at 2.5.11 #343156

merged 1 commit into from
Nov 6, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Sep 20, 2024

Description of changes

Fix #338594

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.mainProgram missing

pkgs/by-name/sl/slackdump/package.nix Outdated Show resolved Hide resolved
@Bot-wxt1221
Copy link
Member Author

I wonder why ofborg fails.

@sarahec
Copy link
Contributor

sarahec commented Sep 26, 2024

I wonder why ofborg fails.

Test failures on Darwin: TestSession_saveUserCache and TestSession_GetUsers. Both fail with exec: "ioreg": executable file not found in $PATH. ioreg is a Darwin system command to get a list of all the hardware devices. man 8 ioreg

I would disable these tests on Darwin.

@Bot-wxt1221
Copy link
Member Author

@sarahec Could we solve it by adding some dependencies because it is a part of darwin?

@sarahec
Copy link
Contributor

sarahec commented Sep 26, 2024

It appears to be a problem with the temporary directories it needs. Other Go modules in this situation include preCheck = "export HOME=(mktemp -d)"; to mitigate this.

--- FAIL: TestSession_saveUserCache (0.00s)
    users_test.go:58:
                Error Trace:    /private/tmp/nix-build-slackdump-2.5.11.drv-0/source/users_test.go:58
                Error:          Received unexpected error:
                                failed to create file /private/tmp/nix-build-slackdump-2.5.11.drv-0/TestSession_saveUserCache2167029744/001/test-UNIT.json: machineid: machineid: exec: "ioreg": executable file not found in $PATH
                Test:           TestSession_saveUserCache
    users_test.go:62: machineid: machineid: exec: "ioreg": executable file not found in $PATH
--- FAIL: TestSession_loadUserCache (0.00s)
    users_test.go:285: failed to create file /private/tmp/nix-build-slackdump-2.5.11.drv-0/TestSession_loadUserCache1141484034/001/2243689666-UNIT: machineid: machineid: exec: "ioreg": executable file not found in $PATH
--- FAIL: TestSession_GetUsers (0.00s)
    users_test.go:285: failed to create file /private/tmp/nix-build-slackdump-2.5.11.drv-0/TestSession_GetUsers2717688092/001/244034912-UNIT: machineid: machineid: exec: "ioreg": executable file not found in $PATH
2024/09/26 23:40:20 messages request #    1, fetched:    1 (threads: 0), total:        1 (speed: 26002.39/sec, avg: 25613.44/sec)

@Bot-wxt1221
Copy link
Member Author

@ofborg build slackdump

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@Bot-wxt1221
Copy link
Member Author

It is said that we don't need to apple_sdk import anymore but it still fails. So I just try this.

@Bot-wxt1221
Copy link
Member Author

@ofborg build slackdump

@Bot-wxt1221
Copy link
Member Author

@ofborg build slackdump

@Bot-wxt1221
Copy link
Member Author

@ofborg build slackdump

@Bot-wxt1221 Bot-wxt1221 requested a review from a team November 3, 2024 14:59
@Bot-wxt1221
Copy link
Member Author

How can we add ioreg to PATH

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
pkgs/by-name/sl/slackdump/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sl/slackdump/package.nix Outdated Show resolved Hide resolved
@Bot-wxt1221
Copy link
Member Author

@niklaskorz Done.

@Bot-wxt1221
Copy link
Member Author

@ofborg build slackdump

@Bot-wxt1221
Copy link
Member Author

@ofborg build slackdump

@niklaskorz
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343156


x86_64-darwin

✅ 1 package built:
  • slackdump

aarch64-darwin

✅ 1 package built:
  • slackdump

@Aleksanaa Aleksanaa merged commit d1baf8d into NixOS:master Nov 6, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: slackdump
10 participants