-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slackdump: init at 2.5.11 #343156
slackdump: init at 2.5.11 #343156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta.mainProgram
missing
932fbf2
to
d51aa0e
Compare
67fdad5
to
ecbc5a1
Compare
ecbc5a1
to
d1632af
Compare
d1632af
to
6a0a177
Compare
I wonder why ofborg fails. |
Test failures on Darwin: I would disable these tests on Darwin. |
@sarahec Could we solve it by adding some dependencies because it is a part of darwin? |
It appears to be a problem with the temporary directories it needs. Other Go modules in this situation include --- FAIL: TestSession_saveUserCache (0.00s)
users_test.go:58:
Error Trace: /private/tmp/nix-build-slackdump-2.5.11.drv-0/source/users_test.go:58
Error: Received unexpected error:
failed to create file /private/tmp/nix-build-slackdump-2.5.11.drv-0/TestSession_saveUserCache2167029744/001/test-UNIT.json: machineid: machineid: exec: "ioreg": executable file not found in $PATH
Test: TestSession_saveUserCache
users_test.go:62: machineid: machineid: exec: "ioreg": executable file not found in $PATH
--- FAIL: TestSession_loadUserCache (0.00s)
users_test.go:285: failed to create file /private/tmp/nix-build-slackdump-2.5.11.drv-0/TestSession_loadUserCache1141484034/001/2243689666-UNIT: machineid: machineid: exec: "ioreg": executable file not found in $PATH
--- FAIL: TestSession_GetUsers (0.00s)
users_test.go:285: failed to create file /private/tmp/nix-build-slackdump-2.5.11.drv-0/TestSession_GetUsers2717688092/001/244034912-UNIT: machineid: machineid: exec: "ioreg": executable file not found in $PATH
2024/09/26 23:40:20 messages request # 1, fetched: 1 (threads: 0), total: 1 (speed: 26002.39/sec, avg: 25613.44/sec) |
6a0a177
to
158731b
Compare
@ofborg build slackdump |
fbe7792
to
f486f28
Compare
It is said that we don't need to apple_sdk import anymore but it still fails. So I just try this. |
@ofborg build slackdump |
f486f28
to
2b82feb
Compare
@ofborg build slackdump |
2b82feb
to
aaa782d
Compare
@ofborg build slackdump |
How can we add ioreg to PATH |
aaa782d
to
f89b588
Compare
f89b588
to
3efb30d
Compare
2a203ec
to
9bbe063
Compare
@niklaskorz Done. |
@ofborg build slackdump |
a988c5b
to
1059702
Compare
@ofborg build slackdump |
|
Description of changes
Fix #338594
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.