-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipet: init at 0.2.1 #343724
pipet: init at 0.2.1 #343724
Conversation
@NixOS/nixpkgs-merge-bot merge |
]; | ||
|
||
doCheck = false; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it can generate completion? https://github.com/bjesus/pipet/blob/1f1469953dd426fc9e33f33e1472618390e155bd/cmd/pipet/main.go#L30
Try something like:
postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) ''
installShellCompletion --cmd pipet \
--bash <($out/bin/pipet completion bash)
'';
This needs installShellFiles
in nativeBuildInputs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it actually works though - pipet completion bash
doesn't do anything. I will look into that in the Pipet project, and if I get it working, I'll make a new Pipet release and update the nixpkg accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify it still works, and squash into two commits:
- maintainers: add bjesus
- pipet: init at 0.2.1
@Aleksanaa thank you so much for your help. I've confirmed it still works, and arranged the commits like you specified. |
Great! But please consider attaching your email ( |
Done, added the email to github. |
Description of changes
This adds a package for pipet, a Golang-based web scrapper. I different platforms mentioned below were tested when compiling manually - I only have Nix running on x86_64-linux. I have set
doCheck
tofalse
because Pipet tests are spinning up a complete web browser.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.