Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipet: init at 0.2.1 #343724

Merged
merged 2 commits into from
Sep 22, 2024
Merged

pipet: init at 0.2.1 #343724

merged 2 commits into from
Sep 22, 2024

Conversation

bjesus
Copy link
Contributor

@bjesus bjesus commented Sep 22, 2024

Description of changes

This adds a package for pipet, a Golang-based web scrapper. I different platforms mentioned below were tested when compiling manually - I only have Nix running on x86_64-linux. I have set doCheck to false because Pipet tests are spinning up a complete web browser.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bjesus
Copy link
Contributor Author

bjesus commented Sep 22, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@bjesus merge not permitted (#305350):
maintainers/maintainer-list.nix is not in pkgs/by-name/

pkgs/by-name/pi/pipet/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pipet/package.nix Outdated Show resolved Hide resolved
];

doCheck = false;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it can generate completion? https://github.com/bjesus/pipet/blob/1f1469953dd426fc9e33f33e1472618390e155bd/cmd/pipet/main.go#L30

Try something like:

postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) ''
  installShellCompletion --cmd pipet \
      --bash <($out/bin/pipet completion bash)
'';

This needs installShellFiles in nativeBuildInputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it actually works though - pipet completion bash doesn't do anything. I will look into that in the Pipet project, and if I get it working, I'll make a new Pipet release and update the nixpkg accordingly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify it still works, and squash into two commits:

  1. maintainers: add bjesus
  2. pipet: init at 0.2.1

@bjesus
Copy link
Contributor Author

bjesus commented Sep 22, 2024

@Aleksanaa thank you so much for your help. I've confirmed it still works, and arranged the commits like you specified.

@Aleksanaa
Copy link
Member

Great! But please consider attaching your email ([email protected]) to your GitHub account so people can find you easily from history overview.

@bjesus
Copy link
Contributor Author

bjesus commented Sep 22, 2024

Done, added the email to github.

@Aleksanaa Aleksanaa changed the title add package for pipet pipet: init at 0.2.1 Sep 22, 2024
@Aleksanaa Aleksanaa merged commit c57e54a into NixOS:master Sep 22, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants