-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
superhtml: init at 0.5.0 #343878
Merged
Merged
superhtml: init at 0.5.0 #343878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertriho
force-pushed
the
superhtml
branch
2 times, most recently
from
September 23, 2024 05:41
0bf7c17
to
32da32c
Compare
Switched to |
petertriho
force-pushed
the
superhtml
branch
from
September 24, 2024 11:32
3af723e
to
9bb203d
Compare
NotAShelf
reviewed
Sep 24, 2024
petertriho
force-pushed
the
superhtml
branch
2 times, most recently
from
September 25, 2024 01:40
e42636b
to
48c9e7d
Compare
matdibu
approved these changes
Sep 25, 2024
@NotAShelf @wegank Is this anything else I need to do to get this merged? |
wegank
reviewed
Sep 29, 2024
petertriho
force-pushed
the
superhtml
branch
from
September 29, 2024 14:19
48c9e7d
to
670c126
Compare
petertriho
force-pushed
the
superhtml
branch
from
September 29, 2024 14:21
670c126
to
65dfda6
Compare
wegank
approved these changes
Sep 29, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds superhtml #340482
I don't use zig and have never packaged any zig projects before so I'm not sure if this the correct way to do things.
zon2nix
doesn't work withsuperhtml
so I just manually made thedeps.nix
file.@matdibu @callumio
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.