Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flclash: init at 0.8.62 #344492

Closed
wants to merge 1 commit into from
Closed

flclash: init at 0.8.62 #344492

wants to merge 1 commit into from

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Sep 25, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 25, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 25, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 25, 2024
Bot-wxt1221
Bot-wxt1221 reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs!

pkgs/by-name/fl/flclash/package.nix Show resolved Hide resolved
pkgs/by-name/fl/flclash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fl/flclash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fl/flclash/package.nix Outdated Show resolved Hide resolved
@aucub aucub force-pushed the flclash branch 4 times, most recently from b3c801f to 0a73047 Compare September 26, 2024 19:02
@aucub aucub changed the title flclash: init at 0.8.61 flclash: init at 0.8.62 Sep 26, 2024
@Bot-wxt1221
Copy link
Member

@aucub My conversation was not solved. Post error you met while solving these problem. Anyway, I think it shouldn't be merged if we can't fetch source without ssh.

@Bot-wxt1221
Copy link
Member

Bot-wxt1221 commented Sep 29, 2024 •
edited
Loading

@aucub Oh I get it. How about buildPhase for buildGoModule? I will try to solve the problem now.

Bot-wxt1221
Bot-wxt1221 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 29, 2024
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 2, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Oct 2, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 2, 2024
@aucub aucub closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: flclash
4 participants
@aucub @Bot-wxt1221 @wegank @NixOSInfra