-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gsts: init 5.0.3 #344604
base: master
Are you sure you want to change the base?
gsts: init 5.0.3 #344604
Conversation
This is currently not working. I am running into this error when trying to build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message doesn't follow contributing guidelines.
@@ -105,6 +105,7 @@ | |||
, "graphql-cli" | |||
, "graphql-language-service-cli" | |||
, "grunt-cli" | |||
, "gsts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use buildNpmPackage
instead. See #229475.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment @dotlambda.
Would you happen to know how to address the error in #344604 (comment)?
🙏
I have managed to get another error by adding this below to npmFlags = [ "--silent" ];
and I think better error with below added; makeCacheWritable = true;
However couldn't progress further |
fix #344461
Description of changes
Things done
- Modify pkgs/development/node-packages/node-packages.json to add, update or remove package entries to have it included in nodePackages and nodePackages_latest.
Run the script: ./pkgs/development/node-packages/generate.sh
Built on platform(s)
For non-Linux: Is sandboxing enabled in
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
Tested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/
)24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
Fits CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.