Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regal: add ldflags to show version #345059

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

rinx
Copy link
Member

@rinx rinx commented Sep 28, 2024

Description of changes

In this pull request, add ldflags to build function of regal package.
I added several flags, mainly for injecting version information.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module

It works as expected.

[nix-shell:~/.cache/nixpkgs-review/rev-bf911d25639f1a5858578cc7b0e12fadad57eb59]$ ./results/regal/bin/regal version
Version:    0.27.0
Go Version: go1.22.7
Platform:   linux/amd64
Commit:     unknown
Timestamp:  unknown
Hostname:   unknown

Add a 👍 reaction to pull requests you find important.

this is used by `version` subcommand

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx
Copy link
Member Author

rinx commented Sep 28, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@rinx merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@Mic92 Mic92 merged commit 0631105 into NixOS:master Sep 28, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants