deck: 1.40.2 -> 1.40.3

[Bot-wxt1221]

Description of changes

Fix build https://hydra.nixos.org/build/274111751/nixlog/1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[liyangau]

Thanks for the PR. A couple changes that I was not aware of like the default formatter seems to be changed to the new rfc nixfmt. I remember failing the formatting test not long ago in a separate PR.

Anyway, should we worry about the failed OfBorg passthru test? I can build it successfully locally on my X86_64-linux machine.

[Bot-wxt1221]

@ofborg build

[Bot-wxt1221]

@ofborg build

[Bot-wxt1221]

@ofborg build deck

[liyangau]

@NixOS/nixpkgs-merge-bot merge

[nixpkgs-merge-bot]

@liyangau merge not permitted (#305350):
pkgs/top-level/all-packages.nix is not in pkgs/by-name/

[liyangau]

ok. I guess I will wait for the next PR to use the merge bot.

By the way, I see two ways of using buildGo123Module, either use it directly on package.nix or pass argument to callPackage.

Both works, which one is preferred?

[Bot-wxt1221]

@liyangau Currently only update bot's PR can be merged by nixpkgs-merge-bot. define it in all-packages.nix is better I think because people can override it by buildGoModule = xxx instead of buildGo123Module = xxx. It will be helpful if we update it.