Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitcode: init at 0.30.0 #345111

Merged
merged 2 commits into from
Oct 5, 2024
Merged

splitcode: init at 0.30.0 #345111

merged 2 commits into from
Oct 5, 2024

Conversation

zimward
Copy link
Contributor

@zimward zimward commented Sep 28, 2024

Description of changes

Adds splitcode package. Closes #343780

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 28, 2024
@nbraud
Copy link
Contributor

nbraud commented Sep 28, 2024

Result of nixpkgs-review pr 345111 run on aarch64-darwin 1

1 package built:
  • splitcode

@melvyn2
Copy link
Contributor

melvyn2 commented Sep 29, 2024

Result of nixpkgs-review pr 345111 run on x86_64-linux 1

1 package built:
  • splitcode

@melvyn2 melvyn2 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 29, 2024
@SuperSandro2000 SuperSandro2000 merged commit 7eb7813 into NixOS:master Oct 5, 2024
28 checks passed
@zimward zimward deleted the splitcode branch October 5, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: splitcode
4 participants