Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dooit: Fix textual version #345228

Merged
merged 1 commit into from
Sep 30, 2024
Merged

dooit: Fix textual version #345228

merged 1 commit into from
Sep 30, 2024

Conversation

kraanzu
Copy link
Member

@kraanzu kraanzu commented Sep 29, 2024

Description of changes

Fix: Dooit's dep textual

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor

Can you reword the commit, please. dooit: fix textual version

@khaneliman
Copy link
Contributor

Running nixpkgs-review now, since it's your application I'll trust the version change fixes the behavior to your expectation.

@kraanzu
Copy link
Member Author

kraanzu commented Sep 29, 2024

Hmmm... I did the changes you mentioned and its still not building. Something with version, I'll check again. Sorry for the trouble :(

khaneliman
khaneliman reviewed Sep 29, 2024
View reviewed changes
pkgs/by-name/do/dooit/package.nix Outdated
@@ -34,6 +33,21 @@ python3.pkgs.buildPythonApplication rec {
python-dateutil
pyyaml
textual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
textual

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the other reference got left in there, so it's picking up the new version, as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh lol hahaha

@khaneliman
Copy link
Contributor

Alright, kicking off a review. Hopefully everything works, thanks for taking this on!

@kraanzu
Copy link
Member Author

kraanzu commented Sep 29, 2024

Alright. Its fine now. Thanks a lot for your time! much appreciated

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 345228

x86_64-linux

✅ 2 packages built:
  • dooit
  • dooit.dist

x86_64-darwin

✅ 2 packages built:
  • dooit
  • dooit.dist

aarch64-darwin

✅ 2 packages built:
  • dooit
  • dooit.dist

@kraanzu kraanzu changed the title fix: dooit package dooit: Fix textual version Sep 29, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 29, 2024
wesleyjrz
wesleyjrz approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@wesleyjrz wesleyjrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result on x86_64-linux.

2 packages built:
  • dooit
  • dooit.dist

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 30, 2024
@khaneliman
Copy link
Contributor

khaneliman commented Sep 30, 2024 •
edited
Loading

Looks like dooit is broken on master now from a textual update #344813. This fixes it not even running, too. Discovered incidentally in #345234 (comment) but locking textual fixes the error we're seeing. Seems the ryantm auto updates must only run the version check on the package being updated but doesn't run the tests on the dependencies that get rebuilt.

@kirillrdy kirillrdy merged commit 1d71b24 into NixOS:master Sep 30, 2024
36 checks passed
@khaneliman khaneliman mentioned this pull request Oct 1, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyjrz wesleyjrz wesleyjrz approved these changes

@khaneliman khaneliman Awaiting requested review from khaneliman

@drupol drupol Awaiting requested review from drupol

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kraanzu @khaneliman @wesleyjrz @kirillrdy @wegank