cables: init at 0.3.2 #345452
Merged
cables: init at 0.3.2 #345452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
RubikCubed
force-pushed
the
cables
branch
2 times, most recently
from
70c514a
to
3ae05a9
Compare
ofborg
bot
added
8.has: package (new)
h7x4
reviewed
Sep 30, 2024
|
@h7x4 Thanks for the welcome and the feedback, I will get this fixed up soon |
RubikCubed
force-pushed
the
cables
branch
2 times, most recently
from
bd786bc
to
7847cbe
Compare
Co-authored-by: h7x4 <[email protected]>
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
|
@h7x4 I've fixed up all the changes and retested, how's it looking now? |
|
Looks pretty good to me. Just one comment left over |
|
@h7x4 Anything else I need to do here? |
|
No, probably fine :) |
h7x4
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This package is for the standalone (electron) version of cables from https://cables.gl/standalone.
I mostly followed https://wiki.nixos.org/wiki/Appimage and would appreciate any feedback, improvements or suggestions.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.