aliases.nix: throw aliases before 2022 #349431
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4710 |
There was a problem hiding this comment.
verified the diff with
diff \
<(cat 349431.patch | grep -E '^- ' | cut -c2- | sd ' (.*) = (.*); #.*' ' $1 = throw "'"'"'$1'"'"' has been renamed to/replaced by '"'"'$2'"'"'"; # Converted to throw 2024-10-17' ) \
<(cat 349431.patch | grep -E '^\+ ' | cut -c2- )
| paperless-ng = paperless-ngx; # Added 2022-04-11 | ||
| parity = throw "parity, renamed to openethereum, has been terminated by upstream"; # Added 2020-08-01 |
There was a problem hiding this comment.
This is the only differing line, which LGTM
|
Oops, this has broken |
|
How? It builds fine for me |
|
I had to remove it to successfully build my profile, commit at drupol/nixos-x260@f4a3a90 |
|
|
|
Why? We still maintain the same number of attributes, they're just much more unfriendly now. |
|
Would you rather we skip straight to dropping them? |
Bad idea imho. It would defeat the purpose of aliases.nix file. Let's wait one or two releases to drop the aliases. |
|
|
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.