-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
janus-gateway: fix build, 1.2.3 -> 1.2.4 #350103
Conversation
CC @jackwilsdon. This fixes the build, but I'm not sure how to test if the resulting binary works as expected. Could you see if this works for you? |
I don't really know how to test it sorry - it's depended upon by I did manage to get it to start a web server with your changes using this sample configuration: https://github.com/meetecho/janus-gateway/blob/b092e3d342c997e45dd3918952ea7d638b921e1e/conf/janus.transport.http.jcfg.sample |
e770a69
to
850d9bb
Compare
850d9bb
to
ff111f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Force-pushed small typo fix for the comment, added reformat, by-name migration and version bump while we are at it. Unfortunately the new version with the included fix mentioned in the upstream issue doesn't fix the build for us.
Fixes #350048
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.