Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janus-gateway: fix build, 1.2.3 -> 1.2.4 #350103

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

xokdvium
Copy link
Contributor

Fixes #350048

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@xokdvium
Copy link
Contributor Author

CC @jackwilsdon. This fixes the build, but I'm not sure how to test if the resulting binary works as expected. Could you see if this works for you?

@jackwilsdon
Copy link
Contributor

jackwilsdon commented Oct 20, 2024

I don't really know how to test it sorry - it's depended upon by ustreamer (which I use), but I don't use the janus-gateway integration.

I did manage to get it to start a web server with your changes using this sample configuration: https://github.com/meetecho/janus-gateway/blob/b092e3d342c997e45dd3918952ea7d638b921e1e/conf/janus.transport.http.jcfg.sample

@ofborg ofborg bot requested a review from fpletz October 21, 2024 00:05
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Oct 21, 2024
@fpletz fpletz force-pushed the dev/fix-janus-gateway-build branch from 850d9bb to ff111f8 Compare October 23, 2024 14:33
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Force-pushed small typo fix for the comment, added reformat, by-name migration and version bump while we are at it. Unfortunately the new version with the included fix mentioned in the upstream issue doesn't fix the build for us.

@fpletz fpletz changed the title janus-gateway: fix build janus-gateway: fix build, 1.2.3 -> 1.2.4 Oct 23, 2024
@ofborg ofborg bot requested a review from fpletz October 23, 2024 16:39
@fpletz fpletz merged commit 0e33e80 into NixOS:master Oct 23, 2024
32 of 33 checks passed
@xokdvium xokdvium deleted the dev/fix-janus-gateway-build branch October 24, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: janus-gateway
4 participants