python3Packages.pymunk: 6.5.2-> 6.9.0, convert to pyproject, fix cross #354101
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/viblo/pymunk/blob/master/CHANGELOG.rst
Before this change the build process fails for
nix build .#pkgsCross.aarch64-multiplatform.python3Packages.pymunk
, but addingcffi
to nativeBuildInputs fixes it.I've tested this change at runtime as well by cross-compiling a Python env with this package, copying the closure to a Raspberry Pi 4, and importing the module on the Raspberry Pi. The build machine is
x86_64
and binfmt is disabled (checked by trying to run the cross-compiled environment, and I correctly got "cannot execute binary file: Exec format error").nix path-info -r ./result | grep -v aarch
returns no results so it looks clean to me.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.