Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pymunk: 6.5.2-> 6.9.0, convert to pyproject, fix cross #354101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SFrijters
Copy link
Member

@SFrijters SFrijters commented Nov 6, 2024

https://github.com/viblo/pymunk/blob/master/CHANGELOG.rst

Before this change the build process fails for nix build .#pkgsCross.aarch64-multiplatform.python3Packages.pymunk, but adding cffi to nativeBuildInputs fixes it.

I've tested this change at runtime as well by cross-compiling a Python env with this package, copying the closure to a Raspberry Pi 4, and importing the module on the Raspberry Pi. The build machine is x86_64 and binfmt is disabled (checked by trying to run the cross-compiled environment, and I correctly got "cannot execute binary file: Exec format error"). nix path-info -r ./result | grep -v aarch returns no results so it looks clean to me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant