-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neohtop: init at 1.0.8 #354565
neohtop: init at 1.0.8 #354565
Conversation
63853df
to
05e22f1
Compare
Please include word fix/close before issue mention to close it automatically on merge |
Was an oversight on my part, done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, I think it would be better if it's built from source via cargo-tauri.hook
— repacking binary artifacts from upstream should only be used for closed-source packages or as a last resort (e.g. exceedingly complicated compilation/circular dependencies/bootstrapping issues)
Been messing around with it for a couple of hours now and I don't think I can progress further or build it from source as is (although this is likely a skill issue). NeoHtop is a tauri v2 application, but I have tried overwriting the version of tauri in So unless someone else wants to take a crack at it, I will probably not be able to progress further till Should I move my PR to a draft for the time being? |
I think you can just base your PR on the tauri v2 PR and not merge until that one is merged |
05e22f1
to
b02cacd
Compare
b02cacd
to
400ab14
Compare
I am closing the PR. From my understanding as of tauri v2, tauri is affected by a bug in cargo in relation to weak dependencies (I do not think this is unique to neohtop, rather this affects all tauri v2 projects). This means that The fix to this is to copy what has been done with surrealist, which involves patching |
NeoHtop is a new cross-platform desktop application for system monitoring.
It was released recently and has already gotten quite a bit of attention, including requests for it to be packaged.
Close #354007
I have pretty much just followed the approach of Hoppscotch, as they are both Tauri applications and they should function similarly.
I would also appreciate feedback on darwin, as I have no way to test that myself.
This is my first time contributing, so I appreciate any and all feedback.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.