Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neohtop: init at 1.0.8 #354565

Closed
wants to merge 1 commit into from
Closed

Conversation

thegrubster
Copy link

@thegrubster thegrubster commented Nov 8, 2024

NeoHtop is a new cross-platform desktop application for system monitoring.

It was released recently and has already gotten quite a bit of attention, including requests for it to be packaged.

Close #354007

I have pretty much just followed the approach of Hoppscotch, as they are both Tauri applications and they should function similarly.

I would also appreciate feedback on darwin, as I have no way to test that myself.

This is my first time contributing, so I appreciate any and all feedback.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 8, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 8, 2024
@thegrubster thegrubster force-pushed the neohtop-init branch 2 times, most recently from 63853df to 05e22f1 Compare November 8, 2024 19:29
@istudyatuni
Copy link
Contributor

Please include word fix/close before issue mention to close it automatically on merge

@thegrubster
Copy link
Author

Please include word fix/close before issue mention to close it automatically on merge

Was an oversight on my part, done now.

Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I think it would be better if it's built from source via cargo-tauri.hook — repacking binary artifacts from upstream should only be used for closed-source packages or as a last resort (e.g. exceedingly complicated compilation/circular dependencies/bootstrapping issues)

@thegrubster
Copy link
Author

If possible, I think it would be better if it's built from source via cargo-tauri.hook — repacking binary artifacts from upstream should only be used for closed-source packages or as a last resort (e.g. exceedingly complicated compilation/circular dependencies/bootstrapping issues)

Been messing around with it for a couple of hours now and I don't think I can progress further or build it from source as is (although this is likely a skill issue).

NeoHtop is a tauri v2 application, but cargo-tauri for the time being is still in v1 (waiting on #346277).

I have tried overwriting the version of tauri in cargo-tauri similar to this but I have been unsuccessful and get some errors from the tauri derivation that I do not know how to get around.

So unless someone else wants to take a crack at it, I will probably not be able to progress further till cargo-tauri is updated to v2.

Should I move my PR to a draft for the time being?

@pluiedev
Copy link
Contributor

I think you can just base your PR on the tauri v2 PR and not merge until that one is merged

@thegrubster
Copy link
Author

I am closing the PR.
I have tried to the best of my ability to package this, but I cannot get it to work.

From my understanding as of tauri v2, tauri is affected by a bug in cargo in relation to weak dependencies (I do not think this is unique to neohtop, rather this affects all tauri v2 projects).

This means that hyper-tls cannot be found in the vendored dependencies (because it is an optional dependency) and is therefore not added correctly.

The fix to this is to copy what has been done with surrealist, which involves patching Cargo.toml and Cargo.lock to correctly include the hyper-tls dependency. But I cannot get this approach to work, and I cannot be bothered wasting more of my time trying to get this to work.

@thegrubster thegrubster deleted the neohtop-init branch November 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: neohtop
4 participants