xonsh.xontribs.xontrib-*: init at various #354733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
Hopefully you can get some actual traction on this. Having pushed a lot more packages since I initially made this, the feedback that might come could include a request to change all of the separate xontrib packages into individual commits to match the commit message log preference for introducing new packages. |
Infinidoge
force-pushed
the
add_xontrib_pkgs
branch
from
144030b
to
5900db4
Compare
|
Do those commit messages seem better? |
|
Yes, that seems to match the format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241386
Supersedes the above PR, I've gone ahead and updated and cleaned up all of the packages (including a small fix for
xontrib-jupyter, after an upstream Xonsh change.) It has also been rebased on master accordingly.I am very driven to get this done to let nix-community/home-manager#5494 proceed, as I have wanted to switch to Xonsh for a while now.
CC @greg-hellings as author of the previous PR
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.