-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixVersions.nix_2_25: init at 2.25.2 #355350
base: master
Are you sure you want to change the base?
Conversation
Things that need to be tested:
I can probably run most of the reviews later on. |
I would suggest to split the PR into two. First one just adds 2.25 and the second one does the actual switch. If in the future it turns out that the switch goes smoothly we can upgrade nix right away. |
You want the |
Yes I think this would speed up the process a bit. |
|
|
It'd be nice if we started leveraging the new meson build system, I think, but that can happen in another PR as well |
Both failures are due to |
|
That's a bit more involved. @roberth has something for it in the works. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.