-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.duckduckgo-search: 6.3.2 -> 6.3.4; python312Packages.primp: 0.6.4 -> 0.6.5 #355393
Open
drawbu
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
drawbu:update-duckduckgo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@drupol I up'd your package version to the latest release. |
Result of 10 packages built:
|
drupol
reviewed
Nov 12, 2024
drawbu
force-pushed
the
update-duckduckgo
branch
from
November 12, 2024 14:54
4adb8ee
to
731c512
Compare
drupol
requested changes
Nov 12, 2024
drupol
changed the title
python3Packages.duckduckgo-search: 6.3.2 -> 6.3.4; python3Packages.primp: 0.6.4 -> 0.6.5
python312Packages.duckduckgo-search: 6.3.2 -> 6.3.4; python312Packages.primp: 0.6.4 -> 0.6.5
Nov 13, 2024
drupol
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit log messages should be using python312Packages
instead of python3Packages
.
python3Packages.duckduckgo-search: use refs/tags for rev Co-authored-by: Pol Dellaiera <[email protected]>
drawbu
force-pushed
the
update-duckduckgo
branch
from
November 13, 2024 14:07
011f083
to
06d09b0
Compare
drupol
approved these changes
Nov 13, 2024
wegank
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.