Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.duckduckgo-search: 6.3.2 -> 6.3.4; python312Packages.primp: 0.6.4 -> 0.6.5 #355393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drawbu
Copy link
Contributor

@drawbu drawbu commented Nov 12, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drawbu drawbu self-assigned this Nov 12, 2024
@drawbu
Copy link
Contributor Author

drawbu commented Nov 12, 2024

@drupol I up'd your package version to the latest release.
Let me know if there is anything I did wrong :)

@drawbu drawbu requested a review from drupol November 12, 2024 10:52
@drawbu drawbu marked this pull request as ready for review November 12, 2024 10:52
@drawbu
Copy link
Contributor Author

drawbu commented Nov 12, 2024

Result of nixpkgs-review pr 355393 run on x86_64-linux 1

10 packages built:
  • open-webui
  • open-webui.dist
  • python311Packages.duckduckgo-search
  • python311Packages.duckduckgo-search.dist
  • python311Packages.primp
  • python311Packages.primp.dist
  • python312Packages.duckduckgo-search
  • python312Packages.duckduckgo-search.dist
  • python312Packages.primp
  • python312Packages.primp.dist

@ofborg ofborg bot requested a review from drupol November 13, 2024 02:11
@drupol drupol changed the title python3Packages.duckduckgo-search: 6.3.2 -> 6.3.4; python3Packages.primp: 0.6.4 -> 0.6.5 python312Packages.duckduckgo-search: 6.3.2 -> 6.3.4; python312Packages.primp: 0.6.4 -> 0.6.5 Nov 13, 2024
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit log messages should be using python312Packages instead of python3Packages.

drawbu and others added 2 commits November 13, 2024 15:06
python3Packages.duckduckgo-search: use refs/tags for rev

Co-authored-by: Pol Dellaiera <[email protected]>
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants