Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pybind11-stubgen: init at 2.5.1 #355442

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

qbisi
Copy link
Contributor

@qbisi qbisi commented Nov 12, 2024

Things done

  1. add bsd3Lbnl license
  2. new python312packages pybind11-stubgen

pybind11-stubgen provide binary exec pybind11-stubgen to generate python stub file for those pybind11 projects.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: lib The Nixpkgs function library labels Nov 12, 2024
@qbisi qbisi marked this pull request as draft November 12, 2024 14:22
@qbisi qbisi marked this pull request as ready for review November 12, 2024 14:24
@qbisi qbisi mentioned this pull request Nov 12, 2024
13 tasks
@qbisi
Copy link
Contributor Author

qbisi commented Nov 12, 2024

doCheck=false

For test purpose, upstream src use shell script to build pybind11 project and diff generated stub file with preset one,
the procedure require network access and cost a lot time building.
So i disabled the checkPhase.

Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, waiting for ofborg.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 13, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2024
@NickCao NickCao merged commit 189f5dc into NixOS:master Nov 13, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants