Add railsy at 0.1.1 #356107
Add railsy at 0.1.1 #356107
Conversation
github-actions
bot
added
the
8.has: maintainer-list (update)
|
The name of the commit adding yourself to the maintainers list should be |
railsy: add at 0.1.1
| @@ -0,0 +1,41 @@ | |||
| { | |||
There was a problem hiding this comment.
These changes are in the wrong commit, they should be in railsy: init ...
| @@ -5148,6 +5148,8 @@ with pkgs; | |||
|
|
|||
| rainbowstream = with python3.pkgs; toPythonApplication rainbowstream; | |||
|
|
|||
| railsy = callPackage ../by-name/ra/railsy { }; | |||
There was a problem hiding this comment.
I could be wrong, but is this necessary with the package in /by-name/? I think you can remove this and it'd be fine
There was a problem hiding this comment.
@steeleduncan You are right. Please remove this line.
| src = fetchFromGitHub { | ||
| owner = "mmkaram"; | ||
| repo = "railsy"; | ||
| rev = "ref/tags/v${version}"; |
There was a problem hiding this comment.
When I tried building this, there is no such tag in the mmkaram/railsy repo, you'd need to add it, or use a commit as the rev
|
By the way, it is not for me to decide, but this looks a lot like an early stage project, with very few commits or users. I think it is unlikely to be picked up to be merged into |
|
Hi @mmkaram! Thanks for the contribution but I would suggest you to read the pkgs/README and search for some similar PR examples to see if something can be learned or borrowed before submitting a PR. It will save our time. As you can see, there are thousands of PRs not reviewed.
|
|
Hey duncan and cu1ch3n, thank you guys for the feedback! I'll get to all these action items and check out the NUR. Have a good one! |
Description of changes
added railsy package, homepage
added mmkaram to maintainer-list
added default.nix to railsy in pkgs/by-name/railsy
added required top level definitions
This is my first attempt at adding a package to nixpkgs, so please let me know if I did anything wrong
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)