Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nicotine-plus: 3.3.5 -> 3.3.6 #356319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amadaluzia
Copy link

I have done some refactoring in the nicotine-plus package to fix libadwaita being an issue, (you may test this with running nicotine-plus with NICOTINE_LIBADWAITA="1") and updated the package from 3.3.5 to 3.3.6.

You may read about changes made in 3.3.6 here: https://nicotine-plus.org/NEWS.html

This introduces a renderer change which may affect some computers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 16, 2024
@amadaluzia
Copy link
Author

amadaluzia commented Nov 16, 2024

Tested the ability to see shares, tested libadwaita functionality, opening a chatroom, looking at profiles and all has seemed to be fine to me.


Damnit, emacs...

Will try and editorconfig the package, apologies.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 16, 2024
@amadaluzia amadaluzia force-pushed the update-nicotine-plus branch 2 times, most recently from 2d62cbd to 743c132 Compare November 16, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants