-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gcc ng #40637
Feature/gcc ng #40637
Conversation
@Ericson2314 as I mentioned earlier... This is a rather rough cut, and it doesn't allow me to build packages with it yet, due to some missing headers (e.g. mingw-w64) isn't properly injected into the CFLAGS, and as such building packages like The general idea:
Finally use 1+4+5+6 to actually have a proper cross gcc. Any suggestions are welcome! PS: Yes, I tried to make this work in the existing gcc expression. I tried to follow the GNU/Hurd appraoch with the libpthreadCross, but could not make it work without constantly running into include/library issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, I don't know enough about both mingw and cross-compilation to say whether this is wanted or a good implementation :)
cc @Ericson2314 for a more general “is this a good idea?” review
binutils | ||
] ++ extraBuildInputs; | ||
|
||
# bould out of tree. We don't use `pwd` in the `configureScript` so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# bould out of tree. We don't use `pwd` in the `configureScript` so | |
# build out of tree. We don't use `pwd` in the `configureScript` so |
@@ -1,7 +1,7 @@ | |||
{ fetchurl, stdenv, mingw_header, hostPlatform, buildPlatform }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the change below,
{ fetchurl, stdenv, mingw_header, hostPlatform, buildPlatform }: | |
{ fetchurl, stdenv, mingw_header }: |
@@ -6092,7 +6092,7 @@ with pkgs; | |||
gerbil-unstable = callPackage ../development/compilers/gerbil/unstable.nix { }; | |||
|
|||
gccFun = callPackage ../development/compilers/gcc/7; | |||
gcc = gcc7; | |||
gcc = gcc7-ng-msvcrt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this setting all gcc to be msvcrt
-based, thus breaking the package for non-windows?
@@ -11433,7 +11482,7 @@ with pkgs; | |||
|
|||
rlog = callPackage ../development/libraries/rlog { }; | |||
|
|||
rocksdb = callPackage ../development/libraries/rocksdb { jemalloc = jemalloc450; }; | |||
rocksdb = callPackage ../development/libraries/rocksdb { stdenv = overrideCC stdenv gcc7-ng-msvcrt; jemalloc = jemalloc450; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, won't setting the compiler to msvcrt
break the package on non-windows?
}; | ||
|
||
buildInputs = [ | ||
gmp mpfr libmpc #libelf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gmp mpfr libmpc #libelf | |
gmp mpfr libmpc |
Or add a comment as to why it is left here
Are there any updates on this pull request, please? |
Thank you for your contributions.
|
Pretty sure this is made obsolete by #132343. Please reopen if not. |
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)