Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik: 1.5.2 -> 1.6.2 #41208

Merged
merged 1 commit into from
May 31, 2018
Merged

traefik: 1.5.2 -> 1.6.2 #41208

merged 1 commit into from
May 31, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented May 29, 2018

Signed-off-by: Vincent Demeester [email protected]

Motivation for this change

Bump version to 1.6.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Signed-off-by: Vincent Demeester <[email protected]>
@ryantm
Copy link
Member

ryantm commented May 29, 2018

@GrahamcOfBorg build traefik

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: traefik

Partial log (click to expand)

/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/7cay2ahwf4hpvjk4m816fid4knphjkcy-traefik-1.6.2...
/nix/store/i9f7115s5x20cwm0p2z5wz6dcs22ssa2-traefik-1.6.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: traefik

Partial log (click to expand)

/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/bc8aa75vsdl70x0hn4ldnrn9xrnmmbsx-traefik-1.6.2-bin

@ryantm
Copy link
Member

ryantm commented May 29, 2018

Nothing else depends on this package so LGTM.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: traefik

Partial log (click to expand)

/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/test-unit: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/update-cert.sh: interpreter directive changed from "/bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/validate-errcheck: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/validate-gofmt: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/validate-golint: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/validate-govet: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/validate-misspell: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
/nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2/share/go/src/github.com/containous/traefik/script/validate-vendor: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/zr0mw2fvy6bpcsr9dyg4p96vn185wkfi-traefik-1.6.2...
/nix/store/fkhkpr64fl4741nxld1ginfb4987a1n8-traefik-1.6.2-bin

@flokli
Copy link
Contributor

flokli commented May 29, 2018

Since 1.6.0, Træfik normally ships a webui (traefik/traefik#2226) at http://localhost:8080/dashboard/, displaying current configuration, status and latest errors (if enabled).

The upstream build process seems to include spinning up a docker container, basically compiling files in webui using ng build --prod --no-delete-output-path --output-path ../static/ (from inside webui folder), which is then baked into the binary using go-bindata.

Our build process leaves the static folder empty, so the dashboard would return a 404.
We should at least document that, but it would be even better if we shipped the dashboard too, as it's really nice :-)

I tried packaging ng and the webui subproject using yarn2nix, while trying to bump this package at an earlier attempt, but wasn't that successful.
I got all dependencies properly nixified, but had problems with building the ng binary itself.

Maybe you can take a look, too?

@flokli
Copy link
Contributor

flokli commented May 29, 2018

as for Profpatsch/yarn2nix, for now I simply tried packaging the node subproject from a Træfik source checkout:

$ cd webui
$ yarn2nix ./jsprotect/yarn.lock > npm-deps.nix
$ yarn2nix --template ./jsproject/package.json > npm-package.nix
# add default.nix from yarn2nix' README, replacing /path/to/yarn2nix
$ nix-build

with yarn2nix pointing to the result of a fresh nix-build of the Profpatsch/yarn2nix repo.

@xeji
Copy link
Contributor

xeji commented May 31, 2018

Let's merge this now. The webui addition should be a separate PR when ready.

@xeji xeji merged commit 9d456bf into NixOS:master May 31, 2018
@vdemeester vdemeester deleted the update-traefik branch May 31, 2018 20:51
@flokli flokli mentioned this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants