Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-fontconfig: regenerate sources using cython #51513

Merged
merged 1 commit into from Dec 5, 2018
Merged

pythonPackages.python-fontconfig: regenerate sources using cython #51513

merged 1 commit into from Dec 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2018

Motivation for this change

Same issue: mcfletch/pyopengl#11
This PR fixes an error when building for python3.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from FRidh as a code owner December 4, 2018 16:06
@Mic92
Copy link
Member

Mic92 commented Dec 4, 2018

@GrahamcOfBorg build pythonPackages.fontconfig

@ghost ghost changed the title pythonPackages.fontconfig: regenerate sources using cython pythonPackages.python-fontconfig: regenerate sources using cython Dec 4, 2018
@ghost
Copy link
Author

ghost commented Dec 4, 2018

@Mic92 Oops, should be pythonPackages.python-fontconfig

@Mic92
Copy link
Member

Mic92 commented Dec 4, 2018

@GrahamcOfBorg build pythonPackages.python-fontconfig

@Mic92
Copy link
Member

Mic92 commented Dec 4, 2018

@GrahamcOfBorg build python3Packages.fontconfig

@ghost
Copy link
Author

ghost commented Dec 5, 2018

@Mic92 build python3Packages.python-fontconfig ?

@Mic92
Copy link
Member

Mic92 commented Dec 5, 2018

@GrahamcOfBorg build python3Packages.python-fontconfig

@Mic92 Mic92 merged commit 4e45eab into NixOS:master Dec 5, 2018
@ghost
Copy link
Author

ghost commented Dec 5, 2018

@Mic92 Thanks!

@ghost ghost deleted the python-fontconfig branch December 5, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @GrahamcOfBorg