Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-12_x: 12.5.0 -> 12.6.0 #64253

Merged
merged 1 commit into from
Jul 3, 2019
Merged

nodejs-12_x: 12.5.0 -> 12.6.0 #64253

merged 1 commit into from
Jul 3, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 3, 2019

Motivation for this change

Changelog: https://github.com/nodejs/node/releases/tag/v12.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam mentioned this pull request Jul 3, 2019
Merged
10 tasks
jonringer
jonringer approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64253 passes
Diff LGTM :)

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64253
2 package were build:
nodejs-12_x nodejs-slim-12_x

@marsam marsam merged commit 6e2ed27 into NixOS:master Jul 3, 2019
@marsam marsam deleted the update-nodejs_v12 branch July 3, 2019 18:59
@thefloweringash
Copy link
Member

Looks like this doesn't build on Darwin: https://hydra.nixos.org/build/95717467

ld: library not found for -latomic
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

@marsam
Copy link
Contributor Author

marsam commented Jul 4, 2019

Sorry about that, I'm reverting it in #64287
node seems to add "-latomic" nodejs/node#28232, which is is a gcc library. I'm not sure why it checks the condition llvm_version!=0

@marsam marsam mentioned this pull request Jul 5, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsam @thefloweringash @jonringer