Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dotnetcore2: init at 2.1.8.1 #67787

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 30, 2019

Motivation for this change

Upstreaming this from an expression I use at work

why someone felt like packaging this instead of telling users to install it... idk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc

includes dotnet-sdk closure, i will try to reduce the size of that package

$ nix path-info -Sh ./result
/nix/store/jxld4i96bfdk76ic904vkvczr50jpq2d-python3.7-dotnetcore2-2.1.8.1        834.4M
$ tree ./result/
./result/
├── lib
│   └── python3.7
│       └── site-packages
│           ├── dotnetcore2
│           │   ├── __init__.py
│           │   └── runtime.py
│           └── dotnetcore2-2.1.8.1.dist-info
│               ├── LICENSE.txt
│               ├── METADATA
│               ├── RECORD
│               ├── top_level.txt
│               └── WHEEL
└── nix-support
    └── propagated-build-inputs
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67787
1 package were build:
python37Packages.dotnetcore2

@jonringer jonringer requested a review from FRidh as a code owner August 30, 2019 19:43
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 30, 2019
@jonringer
Copy link
Contributor Author

@marsam @mmahut do you mind taking a look at this? I'm using this at work and seems to work fine.

@marsam marsam merged commit 55bed3d into NixOS:master Sep 24, 2019
@jonringer jonringer deleted the add-python3-dotnetcore2 branch September 24, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants