Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.celery: fix tests #68703

Merged
merged 1 commit into from
Sep 15, 2019
Merged

pythonPackage.celery: fix tests #68703

merged 1 commit into from
Sep 15, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 13, 2019 •
edited
Loading

Motivation for this change

helping with #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[3 built, 4 copied (47.5 MiB), 6.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68703
4 package were build:
python27Packages.celery python27Packages.djmail python37Packages.celery python37Packages.djmail

[nix-shell:~/.cache/nix-review/pr-68703]$ nix path-info -Sh ./results/*
/nix/store/hbfac8lzm3zb8qyqgg515xjdyvw15gn1-python3.7-djmail-1.1.0       136.9M
/nix/store/i5411sx418xp5ak34bvq07x7b6vg4xjw-python2.7-celery-4.3.0       104.3M
/nix/store/mdvq25rkrprvj5cq7rcjingvcs9cadl5-python2.7-djmail-1.1.0       137.1M
/nix/store/zrddd3cf2xs8l0069dpp1ws1iy27az2w-python3.7-celery-4.3.0       105.2M

@marsam marsam merged commit 87cd31d into NixOS:master Sep 15, 2019
@jonringer jonringer deleted the fix-celery branch September 16, 2019 10:59
@jonringer
Copy link
Contributor Author

@Ma27 @marsam this needs a backport to 19:09, hydra still failing

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 16, 2019
@Ma27 Ma27 self-assigned this Sep 16, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 16, 2019

Backported as cb2bda9.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@Ma27 Ma27

Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonringer @Ma27 @marsam