Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3: update documentation #70523

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

DianaOlympos
Copy link
Contributor

Motivation for this change

rebar3-open was made the default and the hermetic build of rebar3 was deleted in #54115. This update the documentation to be up to date with the state of rebar3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x ] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ankhers maybe ?

@ofborg ofborg bot added 6.topic: erlang 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 6, 2019
@ankhers
Copy link
Contributor

ankhers commented Oct 6, 2019

Looks fine to me.

@veprbl veprbl merged commit 0ce30f8 into NixOS:master Oct 6, 2019
worldofpeace pushed a commit that referenced this pull request Oct 7, 2019
@worldofpeace
Copy link
Contributor

backported in 4c6b739

@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 7, 2019
@DianaOlympos DianaOlympos deleted the fix/rebar3-documentation-update branch October 7, 2019 09:07
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: erlang 8.has: documentation 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants