-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncserver: remove pkgs/module/dependencies #74725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GrahamcOfBorg eval |
nixos/modules/rename.nix
Outdated
@@ -82,6 +82,8 @@ with lib; | |||
# rmilter/rspamd | |||
(mkRemovedOptionModule [ "services" "rmilter" ] "Use services.rspamd.* instead to set up milter service") | |||
|
|||
(mkRemovedOptionModule [ "services" "firefox" "syncserver" ] "Syncserver uses out-dated python2 libraries. Upstream works on new Rust implementation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this one is still wrong.
cc @Nadrieril |
Ah well, that's sad :( But if it's broken and upstream is not working on Python3, then I guess we have no choice |
Well there is the possibility of introducing older versions of those packages, so we're not choiceless, but not sure how good that choice would be. |
This package was up for removal several times. @Nadrieril then took up maintainership and kept it working. If you're also willing to maintain the Python 2 packages it depends upon, I suppose it could stay (though Python2 may eventually get marked as insecure). |
No, as much as I would like to, I don't have the bandwith to maintain a couple of outdated python libraries and all of their dependencies |
Since it is probably relevant: What are you migrating to if you are no longer using the synserver module? I guess moving to the mozilla provided service is not an option as otherwise we would never have considered self-hosting? |
Mozilla's new implementation could not be build yet a few months ago. There was one rust library not yet opensourced by google. This could be different now. Apart from that this would be the way to go in future. |
I tried to make it build by rolling back a bunch of python module versions, but I hit #71824 that I have no clue how to fix. I'm ok with removing syncserver altogether, and waiting for the new rust implementation to be usable :( |
@Nadrieril could we get the progress you made? I have also tried something and hit the webtest issue. But I'm willing to give a second shot at it. |
What I did is I tried to build syncserver on the latest 20.03, and whenever there was a dependency issue I rolled back that dependency to a commit where syncserver used to build. After 4-5 deps I hit #71824, but not just in webtest. A few other packages had issues importing paste.deploy. |
Syncserver is python2-only and there are no plans to upgrade to python3 as upstream works on a new Rust implementation. It broke in nixpkgs because some dependencies became python3-only.
I marked this as stale due to inactivity. → More info |
Too lazy to rebase this another time... |
Syncserver is python2-only and there are no plans to upgrade to python3
as upstream works on a new Rust implementation.
It broke in nixpkgs because some dependencies became python3-only.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @