Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncserver: remove pkgs/module/dependencies #74725

Closed
wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 30, 2019

Syncserver is python2-only and there are no plans to upgrade to python3
as upstream works on a new Rust implementation.
It broke in nixpkgs because some dependencies became python3-only.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 30, 2019
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@@ -82,6 +82,8 @@ with lib;
# rmilter/rspamd
(mkRemovedOptionModule [ "services" "rmilter" ] "Use services.rspamd.* instead to set up milter service")

(mkRemovedOptionModule [ "services" "firefox" "syncserver" ] "Syncserver uses out-dated python2 libraries. Upstream works on new Rust implementation")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this one is still wrong.

@FRidh
Copy link
Member

FRidh commented Feb 6, 2020

cc @Nadrieril

@Nadrieril
Copy link
Member

Nadrieril commented Feb 8, 2020

Ah well, that's sad :( But if it's broken and upstream is not working on Python3, then I guess we have no choice

@infinisil
Copy link
Member

Well there is the possibility of introducing older versions of those packages, so we're not choiceless, but not sure how good that choice would be.

@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

This package was up for removal several times. @Nadrieril then took up maintainership and kept it working. If you're also willing to maintain the Python 2 packages it depends upon, I suppose it could stay (though Python2 may eventually get marked as insecure).

@Nadrieril
Copy link
Member

No, as much as I would like to, I don't have the bandwith to maintain a couple of outdated python libraries and all of their dependencies

@andir
Copy link
Member

andir commented Mar 3, 2020

Since it is probably relevant: What are you migrating to if you are no longer using the synserver module? I guess moving to the mozilla provided service is not an option as otherwise we would never have considered self-hosting?

@Mic92
Copy link
Member Author

Mic92 commented Mar 4, 2020

Mozilla's new implementation could not be build yet a few months ago. There was one rust library not yet opensourced by google. This could be different now. Apart from that this would be the way to go in future.

@Nadrieril
Copy link
Member

I tried to make it build by rolling back a bunch of python module versions, but I hit #71824 that I have no clue how to fix. I'm ok with removing syncserver altogether, and waiting for the new rust implementation to be usable :(

@dasj19
Copy link
Contributor

dasj19 commented Jul 14, 2020

@Nadrieril could we get the progress you made? I have also tried something and hit the webtest issue. But I'm willing to give a second shot at it.

@Nadrieril
Copy link
Member

What I did is I tried to build syncserver on the latest 20.03, and whenever there was a dependency issue I rolled back that dependency to a commit where syncserver used to build. After 4-5 deps I hit #71824, but not just in webtest. A few other packages had issues importing paste.deploy.
Sadly I did not keep this around but it shouldn't be too hard to get to the same state yourself

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
Syncserver is python2-only and there are no plans to upgrade to python3
as upstream works on a new Rust implementation.
It broke in nixpkgs because some dependencies became python3-only.
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 28, 2020
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@Mic92
Copy link
Member Author

Mic92 commented Jul 21, 2021

Too lazy to rebase this another time...

@Mic92 Mic92 closed this Jul 21, 2021
@Mic92 Mic92 deleted the syncserver branch July 23, 2021 08:29
@Mic92 Mic92 restored the syncserver branch July 23, 2021 08:29
@Mic92 Mic92 deleted the syncserver branch July 23, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants