Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nscd: set positive hosts caching ttl to 0 #89274

Merged
merged 1 commit into from
Jun 1, 2020
Merged

nixos/nscd: set positive hosts caching ttl to 0 #89274

merged 1 commit into from
Jun 1, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 31, 2020

This effectively disables nscd's built-in hosts cache, which turns out
to be erratic in some cases.

We only use nscd these days as a more ABI-neutral NSS dispatcher
mechanism.

Local caching should still be possible with local resolvers in
/etc/resolv.conf (via the dns NSS module), or without local resolvers
via systemd-networkd (via the resolve nss module)

We don't set enable-cache to no due to
#50316 (comment).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos/nscd: set positive hosts caching ttl to 0
09244cb 
This effectively disables nscd's built-in hosts cache, which turns out
to be erratic in some cases.

We only use nscd these days as a more ABI-neutral NSS dispatcher
mechanism.

Local caching should still be possible with local resolvers in
/etc/resolv.conf (via the `dns` NSS module), or without local resolvers
via systemd-networkd (via the `resolve` nss module)

We don't set enable-cache to no due to
NixOS#50316 (comment).
@flokli flokli requested review from Mic92, arianvp, dasJ and 0x4A6F May 31, 2020 23:18
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 31, 2020
dasJ
dasJ approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flokli flokli merged commit a2eccf3 into NixOS:master Jun 1, 2020
@flokli flokli deleted the nscd-disable-positive-hosts-caching branch June 1, 2020 15:24
@xaverdh xaverdh mentioned this pull request Jul 9, 2020
Closed
@zhenyavinogradov zhenyavinogradov mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@Mic92 Mic92 Mic92 approved these changes

@arianvp arianvp Awaiting requested review from arianvp

@0x4A6F 0x4A6F Awaiting requested review from 0x4A6F

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flokli @Mic92 @dasJ