Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontforge: 20190801 -> 20200314 #89583

Merged
merged 2 commits into from
Jun 7, 2020
Merged

fontforge: 20190801 -> 20200314 #89583

merged 2 commits into from
Jun 7, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jun 6, 2020

Motivation for this change

Fontforge is currently broken on staging. This upgrade seems to fix it. It’s needed by lots of GUI programs because it’s needed to build DejaVu.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from erictapen June 6, 2020 02:49
@alyssais
fontforge: 20190801 -> 20200314
e9848d1 
This fixes the failing build.

Build system changed to cmake.
@alyssais
fontforge: introduce withGUI option
8a74399 
It was unintuitive that the withGTK option controlled whether a
fontforge GUI was enabled at all, since fontforge supports multiple
GUIs (a GTK one and an X11 one -- confusingly the X11 one still
requires GTK).

With the new withGUI option, it is possible to build the X11 GUI by
setting withGTK to false and withGUI to true.  I haven't added an
attribute for this configuration because I expect it to be pretty
obsure -- my rationale for adding this option was code clarity rather
than utility.
@FRidh FRidh merged commit f5a63f1 into NixOS:staging Jun 7, 2020
@erictapen
Copy link
Member

Thanks! Had this on my list for a while but never managed to finish it.

@FRidh FRidh mentioned this pull request Jun 7, 2020
Closed
10 tasks
nh2 added a commit to nh2/nixpkgs that referenced this pull request Jul 29, 2020
@nh2
fontforge: Fix uninterpolated CMAKE_INSTALL_PREFIX in RPATH.
e57bb01 
This was introduced in NixOS#89583
and fixed upstream with a master-only patch in
fontforge/fontforge#4232.

Found via
nh2/static-haskell-nix#98 (comment).
@nh2 nh2 mentioned this pull request Jul 29, 2020
Merged
10 tasks
nh2 added a commit to nh2/nixpkgs that referenced this pull request Jul 29, 2020
@nh2
fontforge: Fix uninterpolated CMAKE_INSTALL_PREFIX in RPATH.
c4c8125 
This was introduced in NixOS#89583
and fixed upstream with a master-only patch in
fontforge/fontforge#4232.

Found via
nh2/static-haskell-nix#98 (comment).
@alyssais alyssais deleted the fontforge branch April 9, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen Awaiting requested review from erictapen

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alyssais @erictapen @nixos-discourse @FRidh