Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia: 0.3.9 -> 0.3.10 #9007

Merged
merged 1 commit into from
Jul 30, 2015
Merged

julia: 0.3.9 -> 0.3.10 #9007

merged 1 commit into from
Jul 30, 2015

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jul 26, 2015

Tests on i686 are also disabled since some of them fail and these failures do not reveal packaging bugs (rather bugs in the test-suite or in julia itself). AFAICT julia is properly built and behaves well on NixOS-i686.

@vcunat
Copy link
Member

vcunat commented Jul 30, 2015

/cc maintainers: @7c6f434c, @ttuegel.

@ttuegel
Copy link
Member

ttuegel commented Jul 30, 2015

I think a fix for the failing test has already been committed upstream. I'm trying to backport it now...

@vbgl
Copy link
Contributor Author

vbgl commented Jul 30, 2015

I tried that too. Patching numbers.jl is easy. Then I hit next failing test.

IIRC, it’s ishermitian(A'A) in arrayops.jl. I’m not sure it has been patched upstream (it seems unclear what this function is supposed to do wrt numerical inaccuracy).

If this test is dropped, then the next failing one is in reduce.jl, also patched upstream.

After this one is fixed, next one is in random.jl.

There I realize all of this was pointless.

@ttuegel
Copy link
Member

ttuegel commented Jul 30, 2015

I see. Mentioning that there were several test failures all related to numerical accuracy would have saved some time. (As a general rule, there is no point in writing tests that depend on numerical accuracy, as they will always fail on some OS, on some platform, somewhere, unless the tolerance is pointlessly large. I had hoped the Julia folks would be acquainted with this fact.)

ttuegel added a commit that referenced this pull request Jul 30, 2015
@ttuegel ttuegel merged commit 942e74b into NixOS:master Jul 30, 2015
@vbgl
Copy link
Contributor Author

vbgl commented Jul 30, 2015

Ok. Sorry for wasting your time.

@ttuegel
Copy link
Member

ttuegel commented Jul 30, 2015

@vbgl Oh, it's no trouble, don't worry about it. I'm mostly irritated that upstream would do something like test numerical equality because (as someone who does numerical computing for a living) I know how useless it is! :)

@vcunat
Copy link
Member

vcunat commented Jul 30, 2015

Hmm, I thought IEEE-754 defines the exact results of operations, but that's rather off-topic...

@ttuegel
Copy link
Member

ttuegel commented Jul 30, 2015

@vcunat Yes, but bit-perfect results still depend on knowing details about the hardware implementation and choice of C library. In theory, it should work predictably, in practice it's a crapshoot.

@vbgl vbgl deleted the julia-3.10 branch July 31, 2015 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants