Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bazel package #9008

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Fix bazel package #9008

merged 1 commit into from
Aug 6, 2015

Commits on Jul 28, 2015

  1. bazel: fix build, make compatible with openjdk

    Bazel 981b7bc1 depends on protobuf-2.5 and won't work with 2.6 (and in
    bbe84fe3d upgraded straight to protobuf 3.0.0-alpha3); this commit fixes
    the dependency to depend on protobuf2_5 specifically.
    
    The bazel compile.sh needs `which` on the PATH; so this commit adds that
    as a dependency.
    
    Setting JAVA_HOME to ${jdk} broke bazel when used with openjdk, with the
    message:
    
        Problem with java installation: couldn't find/access rt.jar in /nix/store/z9vc0vzyzhnpl5l5inmqdnvdnbxmmmg7-openjdk-8u60b24
    
    This is because if you set JAVA_HOME, bazel will look for rt.jar in
    $JAVA_HOME/lib and $JAVA_HOME/jre/lib, but the nixpkgs openjdk
    distribution puts rt.jar in ${jdk}/lib/openjdk/jre/lib for some reason.
    
    To fix this, this commit uses the ${jdk.home} passthru value to use the
    appropriate JAVA_HOME for the given jdk.
    
    As bazel now works with openjdk, and openjdk is free while oraclejdk is
    not, this commit changes the default jdk for bazel to openjdk.
    
    Since this package didn't have a listed maintainer, I'm claiming it.
    philandstuff committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    76dd430 View commit details
    Browse the repository at this point in the history