buildGoModule: remove modSha256

[zowoq]

This is dead code but I'll wait until we're closer to 20.09 before merging.

[Mic92]

Yes. Actually I think should be not merge before the 20.09 branch off. So people that migrate from 20.03 to 20.09 have the time to update their packages - They would get one release time to migrate everything which is the smallest time unit we can give them.

[zowoq]

They would get one release time to migrate everything which is the smallest time unit we can give them.

Why?

[Mic92]

They would get one release time to migrate everything which is the smallest time unit we can give them.

Why?

This was not present in 20.03. If users upgrade to 20.09 all their packages needs an update. If you have a infrastructure large enough, you may not upgrade all installations at once. The branch off is soonish anyway so these 200 lines should not bother us.

[zowoq]

This was not present in 20.03. If users upgrade to 20.09 all their packages needs an update. If you have a infrastructure large enough, you may not upgrade all installations at once.

Yes, it is a breaking change that is documented.

People will need to set vendorSha256 = null anyway to use modSha256 so I don't see why we need to keep it around for another release cycle.

[Mic92]

Ok. Than we can merge it already.

[Mic92]

People that needs to support both can just have both checksums defined in the package.

[Mic92]

Can you convert this in a throw statement that provides instruction to use vendorSha256 instead?

[zowoq]

Changed to throw.

[kalbasit]

People that needs to support both can just have both checksums defined in the package.

With the change to throw the above won't be true anymore. I think it'll be useful for people to support both. Can we throw only if modSha256 is defined but vendorSha256 is not?

[zowoq]

I'd rather we go back to the original which just outright removed modSha256 without throws or warnings.

IMHO the error that vendorSha256 is required is clear and it still allowed people to set modSha256 if needed.

[marsam]

If you are going to merge it before the 20.09 branch-off, please update this bit:

nixpkgs/nixos/doc/manual/release-notes/rl-2009.xml

Lines 205 to 207 in c581528

	attribute to pin fetched version data. <literal>buildGoModule</literal>
	still accepts <literal>modSha256</literal> with a warning, but support will
	be removed in the next release.

[zowoq]

Oh, I didn't realise it said that.

It's been in the 20.09 release notes for a couple of months now, is it okay to change it to proceed with this PR?