-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-update: install man pages #95835
Conversation
CC @JohnTitor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cc'ing! I cannot test it on my local right now but the change itself makes sense, feel free to merge it if it works well :) (btw it'd be nice if the ofborg bot also pinged me, maybe I'm not a part of the maintainer team on the org?)
Seems so. I saw that you already asked about this on Discourse. Maybe someone with the right privileges will get back to it. |
Alright, will wait then :) |
@JohnTitor you could add yourself as maintainer in this package. This way you get mentioned automatically. |
@Gerschtli I am already:
|
That is strange. Maybe your information in |
Maintainers need to be added to the maintainers team of the GitHub NixOS organization. Otherwise, they are not auto-added as reviewers to PRs. Maintainers were automatically invited to this team, but the invite script has been turned off a while ago, due to problems caused by changes in how GitHub handles invitations. See: https://discourse.nixos.org/t/join-the-package-maintainer-team/3751/37 and NixOS/rfcs#39 . |
Ah okay, didn't know that! |
Motivation for this change
Add man pages.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)