Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding oneloop script to script.js #8

Merged
merged 3 commits into from
Apr 9, 2024
Merged

adding oneloop script to script.js #8

merged 3 commits into from
Apr 9, 2024

Conversation

tracykteal
Copy link
Contributor

@tracykteal tracykteal commented Apr 9, 2024 •
edited
Loading

I included the <script> tag, but let me know if you think that's not needed here.

@tracykteal tracykteal requested a review from jmoralez April 9, 2024 17:55
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jmoralez
jmoralez requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script tag is HTML so I don't think it's valid javascript.

script.js Outdated Show resolved Hide resolved
script.js Outdated Show resolved Hide resolved
tracykteal and others added 2 commits April 9, 2024 12:04
@tracykteal @jmoralez
remove <script> tag
8255c47 
Co-authored-by: José Morales <[email protected]>
@tracykteal @jmoralez
remove </script> tag
9a6531d 
Co-authored-by: José Morales <[email protected]>
@jmoralez jmoralez merged commit 97d6357 into main Apr 9, 2024
1 check passed
@jmoralez jmoralez deleted the oneloop branch April 9, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoralez jmoralez jmoralez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tracykteal @CLAassistant @jmoralez