feat: suggest earlier version for azure endpoints #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
jmoralez
commented
Aug 30, 2024
nixtla/nixtla_client.py
Outdated
| raise NotImplementedError( | ||
| "This version doesn't support Azure endpoints, please install " | ||
| "an earlier version with: `pip install 'nixtla<=0.5.2'`" | ||
| ) | ||
| self.supported_models = ["azureai", "timegpt-1-long-horizon"] |
There was a problem hiding this comment.
I'd originally done this to support older azure deployments, but I think this should now just be ["azureai"], right @AzulGarza?
There was a problem hiding this comment.
yes, exactly, thank you @jmoralez
AzulGarza
approved these changes
Aug 30, 2024
nixtla/nixtla_client.py
Outdated
| raise NotImplementedError( | ||
| "This version doesn't support Azure endpoints, please install " | ||
| "an earlier version with: `pip install 'nixtla<=0.5.2'`" | ||
| ) | ||
| self.supported_models = ["azureai", "timegpt-1-long-horizon"] |
There was a problem hiding this comment.
yes, exactly, thank you @jmoralez
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.