Skip to content

Bump MSTest.TestAdapter from 3.5.2 to 3.6.0 in /src #126

Bump MSTest.TestAdapter from 3.5.2 to 3.6.0 in /src

Bump MSTest.TestAdapter from 3.5.2 to 3.6.0 in /src #126

Triggered via pull request September 11, 2024 15:23
Status Failure
Total duration 49s
Artifacts

pull-request.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
build
Process completed with exit code 1.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-dotnet@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build: src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L61
Use at least 100,000 iterations here. (https://rules.sonarsource.com/csharp/RSPEC-5344)
build: src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L61
Rfc2898DeriveBytes might be using a weak hash algorithm. Use SHA256, SHA384, or SHA512 to create a strong key from a password. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5379)
build: src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L66
Symmetric encryption uses non-default initialization vector, which could be potentially repeatable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5401)
build: src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L62
Use at least 100000 iterations when deriving a cryptographic key from a password. By default, Rfc2898DeriveByte's IterationCount is only 1000 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5387)
build: src/DevilDaggersInfo.Core.Wiki/Objects/Enemy.cs#L28
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
build: src/DevilDaggersInfo.Core.Wiki/Objects/Enemy.cs#L32
Use properties where appropriate (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1024)
build: src/DevilDaggersInfo.Core.GameData/V3_2.cs#L6
Remove the underscores from type name DevilDaggersInfo.Core.GameData.V3_2 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
build: src/DevilDaggersInfo.Core.Mod/AssetData.cs#L1
Rename namespace DevilDaggersInfo.Core.Mod so that it no longer conflicts with the reserved language keyword 'Mod'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build: src/DevilDaggersInfo.Core.Mod/AssetData.cs#L13
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
build: src/DevilDaggersInfo.Core.Mod/Builders/AudioModBinaryBuilder.cs#L3
Rename namespace DevilDaggersInfo.Core.Mod.Builders so that it no longer conflicts with the reserved language keyword 'Mod'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)