Merge pull request #90 from NoahStolk/dependabot/nuget/src/Roslynator… #134
NoahStolkAnnotations
12 warnings
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-dotnet@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L61
Use at least 100,000 iterations here. (https://rules.sonarsource.com/csharp/RSPEC-5344)
|
|
build:
src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L61
Rfc2898DeriveBytes might be using a weak hash algorithm. Use SHA256, SHA384, or SHA512 to create a strong key from a password. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5379)
|
|
build:
src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L66
Symmetric encryption uses non-default initialization vector, which could be potentially repeatable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5401)
|
|
build:
src/DevilDaggersInfo.Core.Encryption/AesBase32Wrapper.cs#L62
Use at least 100000 iterations when deriving a cryptographic key from a password. By default, Rfc2898DeriveByte's IterationCount is only 1000 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5387)
|
|
build:
src/DevilDaggersInfo.Core.GameData/V3_2.cs#L6
Remove the underscores from type name DevilDaggersInfo.Core.GameData.V3_2 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
|
build:
src/DevilDaggersInfo.Core.Wiki/Objects/Enemy.cs#L28
Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)
|
|
build:
src/DevilDaggersInfo.Core.Wiki/Objects/Enemy.cs#L32
Use properties where appropriate (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1024)
|
|
build:
src/DevilDaggersInfo.Core.CriteriaExpression/Parts/IExpressionPart.cs#L3
Avoid empty interfaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1040)
|
|
build:
src/DevilDaggersInfo.Core.CriteriaExpression/TargetCollection.cs#L4
Rename type name TargetCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
|
build:
src/DevilDaggersInfo.Core.CriteriaExpression/Expression.cs#L45
Modify 'TryParse' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|