Skip to content

Rewrite replay events #14

Rewrite replay events

Rewrite replay events #14

Triggered via pull request October 16, 2023 17:25
Status Success
Total duration 1m 10s
Artifacts

pull-request.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build: src/DevilDaggersInfo.Core.Wiki/Deaths.cs#L31
Do not forget to remove this deprecated code someday. (https://rules.sonarsource.com/csharp/RSPEC-1133)
build: src/DevilDaggersInfo.Core.CriteriaExpression/Parts/ExpressionOperator.cs#L11
Remove this 'throw' expression. (https://rules.sonarsource.com/csharp/RSPEC-3877)
build: src/DevilDaggersInfo.Core.Spawnset/View/SpawnsView.cs#L83
Change this condition so that it does not always evaluate to 'False'. Some code paths are unreachable. (https://rules.sonarsource.com/csharp/RSPEC-2583)
build: src/DevilDaggersInfo.Core.Replay/ReplayBinary.cs#L55
The variable 'ex' is declared but never used
build: src/DevilDaggersInfo.Core.Replay/PostProcessing/ReplaySimulation/ReplaySimulationBuilder.cs#L114
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
build: src/DevilDaggersInfo.Core.Replay/PostProcessing/ReplaySimulation/ReplaySimulationBuilder.cs#L23
Either change the type of 'e' to 'ReplayEvent' or iterate on a generic collection of type 'IEventData'. (https://rules.sonarsource.com/csharp/RSPEC-3217)
build: src/DevilDaggersInfo.Core.Wiki/Deaths.cs#L31
Do not forget to remove this deprecated code someday. (https://rules.sonarsource.com/csharp/RSPEC-1133)
build: src/DevilDaggersInfo.Core.CriteriaExpression/Parts/ExpressionOperator.cs#L11
Remove this 'throw' expression. (https://rules.sonarsource.com/csharp/RSPEC-3877)
build: src/DevilDaggersInfo.Core.Spawnset/View/SpawnsView.cs#L83
Change this condition so that it does not always evaluate to 'False'. Some code paths are unreachable. (https://rules.sonarsource.com/csharp/RSPEC-2583)
build: src/DevilDaggersInfo.Core.Replay/ReplayBinary.cs#L55
The variable 'ex' is declared but never used