Updated input handling to fix ImGui.Net breaking changes. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled support for docking.
NogginBops
requested changes
Nov 22, 2023
…tandalone per [PR 29 Review](NogginBops#29 (review)) Amending: Updated input handling to fix ImGui.Net breaking changes. Enabled support for docking.
I've been using github since 2017 and I still don't know why it takes me 40+ commits and PR's to change one file, but I'm blaming Visual Studio this time
|
Should be fixed :) |
zaafar
reviewed
Nov 25, 2023
Dear ImGui Sample/ImGuiController.cs
Outdated
| { | ||
| public static ImGuiKey Translate(Keys key) | ||
| { | ||
| switch (key) |
There was a problem hiding this comment.
[optional] you can reduce the length a bit if you do something like this.
https://github.com/zaafar/ClickableTransparentOverlay/blob/master/ClickableTransparentOverlay/ImGuiInputHandler.cs#L161:L172
NogginBops
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed errors caused by changes in latest ImGuiNet * enabled support for docking.