fix: ignore unknown opcode in stack traces (#693)

* fix: ignore unknown opcode in stack traces * Add changeset
NomicFoundation · Oct 2, 2024 · 7047e6c · 7047e6c
1 parent ec998cd
commit 7047e6c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/wicked-tomatoes-vanish.md b/.changeset/wicked-tomatoes-vanish.md
@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/edr": patch
+---
+
+Fixed panic from unknown opcode in stack traces
diff --git a/crates/edr_solidity/src/contracts_identifier.rs b/crates/edr_solidity/src/contracts_identifier.rs
@@ -97,7 +97,12 @@ impl BytecodeTrie {
 fn is_matching_metadata(code: &[u8], last_byte: u32) -> bool {
     let mut byte = 0;
     while byte < last_byte {
-        let opcode = OpCode::new(code[byte as usize]).unwrap();
+        // It's possible we don't recognize the opcode if it's from an unknown chain, so
+        // just return false in that case.
+        let Some(opcode) = OpCode::new(code[byte as usize]) else {
+            return false;
+        };
+
         let next = code.get(byte as usize + 1).copied().and_then(OpCode::new);
 
         if opcode == OpCode::REVERT && next == Some(OpCode::INVALID) {