fix: allow missing nonce in remote blocks (#539)

* fix: allow missing nonce in remote blocks * misc: add changeset
NomicFoundation · Jul 3, 2024 · b056511 · b056511
1 parent dfdd380
commit b056511
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/big-boxes-drop.md b/.changeset/big-boxes-drop.md
@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/edr": patch
+---
+
+Fixes restriction to disallow remote blocks without a nonce
diff --git a/crates/edr_evm/src/block/remote.rs b/crates/edr_evm/src/block/remote.rs
@@ -181,7 +181,9 @@ impl IntoRemoteBlock<L1ChainSpec> for edr_rpc_eth::Block<edr_rpc_eth::Transactio
             // TODO don't accept remote blocks with missing mix hash,
             // see https://github.com/NomicFoundation/edr/issues/518
             mix_hash: self.mix_hash.unwrap_or_default(),
-            nonce: self.nonce.ok_or(CreationError::MissingNonce)?,
+            // TODO don't accept remote blocks with missing nonce,
+            // see https://github.com/NomicFoundation/edr/issues/518
+            nonce: self.nonce.unwrap_or_default(),
             base_fee_per_gas: self.base_fee_per_gas,
             withdrawals_root: self.withdrawals_root,
             blob_gas: self.blob_gas_used.and_then(|gas_used| {